Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Fastfile Loggers Compatible with MacOS #13735

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Make Fastfile Loggers Compatible with MacOS #13735

wants to merge 1 commit into from

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Oct 8, 2024 •
edited
Loading

  • Tests written, or not not needed

@alperozturk96
make loggers compatible with mac os
8d8b8a0 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

Codacy

Lint

TypemasterPR
Warnings5959
Errors33

SpotBugs

CategoryBaseNew
Bad practice6464
Correctness6363
Dodgy code296296
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness66
Performance5353
Security1818
Total509509

@tobiasKaminsky
Copy link
Member

This breaks it then on Linux…
We need to find another solution, that works on both.

tobiasKaminsky
tobiasKaminsky requested changes Oct 8, 2024
View reviewed changes
Copy link
Member

@tobiasKaminsky tobiasKaminsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not working on Linux.
-i parameter is the problem

@alperozturk96 alperozturk96 marked this pull request as draft October 8, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky requested changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
2. developing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alperozturk96 @tobiasKaminsky @AndyScherzinger